Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: destination address format #197

Merged
merged 3 commits into from
Jun 12, 2024
Merged

fix: destination address format #197

merged 3 commits into from
Jun 12, 2024

Conversation

wainola
Copy link
Contributor

@wainola wainola commented May 14, 2024 •
edited
Loading

Description

Fixes issue when entering invalid address format

Related Issue Or Context

Closes: #189

How Has This Been Tested? Testing details.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation

Checklist:

  • I have commented my code, particularly in hard-to-understand areas.
  • I have ensured that all acceptance criteria (or expected behavior) from issue are met
  • I have updated the documentation locally and in sygma-docs.
  • I have added tests to cover my changes.
  • I have ensured that all the checks are passing and green, I've signed the CLA bot

@wainola wainola marked this pull request as ready for review May 15, 2024 01:53
@saadahmsiddiqui
Copy link
Member

2024-05-16.11-12-56.mp4

weird bug that changes text from invalid address to set token amount

@saadahmsiddiqui
Copy link
Member

@wainola im converting it to draft, once we fix the main bug then we can test this out

@saadahmsiddiqui saadahmsiddiqui marked this pull request as draft May 20, 2024 10:43
@wainola
Copy link
Contributor Author

wainola commented May 22, 2024 •
edited
Loading

Update: waiting for #196 to be merged because of the refactor in the buildTransactions method

@LyonSsS LyonSsS mentioned this pull request Jun 10, 2024
Closed
LyonSsS
LyonSsS approved these changes Jun 10, 2024
View reviewed changes
Copy link

@LyonSsS LyonSsS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works fine only for the scope of the issue

@wainola wainola marked this pull request as ready for review June 11, 2024 15:37
@LyonSsS
Copy link

LyonSsS commented Jun 12, 2024

Retested after rebase - works fine

@MakMuftic MakMuftic merged commit 250ea35 into main Jun 12, 2024
4 checks passed
@MakMuftic MakMuftic deleted the fix/destination-address-format branch June 12, 2024 12:29
@MakMuftic MakMuftic mentioned this pull request Jun 12, 2024
Merged
MakMuftic added a commit that referenced this pull request Jun 13, 2024
@MakMuftic
chore: release main (#186)
b4804d5 
🤖 I have created a release *beep* *boop*
---


<details><summary>@buildwithsygma/sygmaprotocol-react-widget:
0.1.3</summary>

### Dependencies

* The following workspace dependencies were updated
  * dependencies
    * @buildwithsygma/sygmaprotocol-widget bumped to 0.2.0
</details>

<details><summary>sygmaprotocol-widget: 0.2.0</summary>

##
[0.2.0](sygmaprotocol-widget-v0.1.2...sygmaprotocol-widget-v0.2.0)
(2024-06-13)


### Features

* automatically add unknown source evm network into wallet
([#162](#162))
([d5886bd](d5886bd))
* display amount to be received on destination
([#168](#168))
([347f7a5](347f7a5))
* Display Fee
([#145](#145))
([872703d](872703d))
* display transfer gas cost estimation
([#174](#174))
([b154555](b154555))
* enable developers to configure network whitelisting
([#170](#170))
([5db505f](5db505f))
* enable user to specify wallets
([#161](#161))
([8a02170](8a02170))
* Retry loading bridge routes
([#136](#136))
([8e0101f](8e0101f))
* substrate fungible transfer
([#134](#134))
([337f1b7](337f1b7))
* wallet account selector for substrate
([#106](#106))
([79127fd](79127fd)),
closes [#74](#74)


### Bug Fixes

* amount to receive
([#196](#196))
([8c2cdad](8c2cdad))
* destination address format
([#197](#197))
([250ea35](250ea35))
* explorer urls when adding networks
([#200](#200))
([d65d99a](d65d99a))
* Fixed amount to receive decimals
([#208](#208))
([be23500](be23500))
* Gas Fee estimation behavior, is not consistent for the actual transfer
TX ([#204](#204))
([d57233e](d57233e))
* handling transfer cancellation on substrate
([#195](#195))
([6ce25cb](6ce25cb))
* resource name
([#201](#201))
([1215dcc](1215dcc))
* resource selector
([#199](#199))
([81bae38](81bae38))
* small fix for tangle connection
([#212](#212))
([557d71e](557d71e))
* source switch reset
([#206](#206))
([1b1f92c](1b1f92c)),
closes [#205](#205)
* typesafety when handling changed properties
([#141](#141))
([692e269](692e269))
</details>

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@saadahmsiddiqui saadahmsiddiqui saadahmsiddiqui approved these changes

@LyonSsS LyonSsS LyonSsS approved these changes

@MakMuftic MakMuftic MakMuftic approved these changes

@Lykhoyda Lykhoyda Awaiting requested review from Lykhoyda Lykhoyda is a code owner

@mpetrunic mpetrunic Awaiting requested review from mpetrunic mpetrunic is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Transfer from EVM to Polkdaot chains, using an invalid destination format, it is still possible
4 participants
@wainola @saadahmsiddiqui @LyonSsS @MakMuftic